silencing the unused lambda capture warning #853
Conversation
libraries/app/api.cpp
Outdated
| @@ -151,7 +151,7 @@ namespace graphene { namespace app { | |||
| { | |||
| auto block_num = b.block_num(); | |||
| auto& callback = _callbacks.find(id)->second; | |||
| fc::async( [capture_this,this,id,block_num,trx_num,trx,callback]() { | |||
| fc::async( [capture_this,id,block_num,trx_num,trx,callback]() { | |||
There was a problem hiding this comment.
I have been working on this line of code for another PR (#813), and can verify that the change above causes no side effects. Unfortunately it doesn't fix 813's problem, but that is another story...
There was a problem hiding this comment.
thanks for confirming that @jmjatlanta
There was a problem hiding this comment.
I want to hear more discussion about this. @pmconrad ?
There was a problem hiding this comment.
Removing "this" shouldn't make a difference. Nevertheless I think we should wait for John's results from #813 before changing this.
There was a problem hiding this comment.
@ihla please revert the change about api.cpp then we'll merge other changes in this PR.
@jmjatlanta please consider removing this in #813 if it's OK to do so.
No description provided.